Set minimal sqlite3 >= 3.45.2 && Boost >= 1.84.0 #230
Conversation
ycagel
requested review from
SmartArray,
JaredTate,
ycagel,
digicontributer,
gto90 and
j50ng
|
How are you going about upgrading Boost? I can't compile
Also, have you tried GUIX with this? |
Looks like a simple That worked to get latest 1.84 and upgrade. Also running |
|
I am getting further build errors now & can't compile:
|
|
After a fresh clone and reboot I can now get it to compile, but now
|
|
I have just tested this on Apple Silicon. It compiled fine and runs. @JaredTate I think you are not using the depends folder, if you have to use brew. |
Yes it compiled for me too, it was |
Yes. There is nothing changed in GUIX. Because Guix already use boost 1.84.0. because of pr194 |
|
I had to bump python version in this line in configure.ac to get things to work locally with my Python env for Line 104 in 99ed14a Changed line to
|
Why not using local depends folder? With include boost 1.84.0 since pr194. |
I have found for speed of testing and development, to rapidly test changes using this build instructions locally: |
Use this. ( Linux example ) cd digibyte/depends //Linux cd .. ./autogen.sh CONFIG_SITE=$PWD/depends/x86_64-linux-gnu/share/config.site ./configure make -j12 //Windows //Windows |
Yes, I am aware & but I am on a Mac. For speed testing & compiling/ testing fixes quicker the traditional local mac build route is faster and I find troubleshooting issues with more flexibility. |
For troubleshooting we obviously always want to use the same libraries. Now you are using the old libraries with PR194 which is what was giving you the problems with this PR - the libraries are not the correct versions. When we do not change the depends folder between versions, you can always make a backup of it, to save you from having to rebuild it every time. So https://github.com/DigiByte-Core/digibyte/blob/develop/doc/build-osx.md is not faster, and may cause issues with incorrect libraries. By using the depends folder, the libraries will always be the same for every build. This is what GUIX uses. |
I pulled this change from here, am testing python functional tests now: |
I agree, we need to use same deps, but real world that wont always be case and others will run into issues too. Once I updated my local environment to match, it compiled and I discovered we needed to bump Python V in configure.ac. Real world issue. Also Mac with depends it is a pain in the arse.. you have to manually extract the SDK because of apple licensing. Why do that when I can already have the built-in xcode SDK functionality native to my OS after I do OSX updates. Much quicker to use build-osx when natively on a mac. Especially when recompiling over and over and over again.
Guess where depends instructions send you, same place as GUIX oSX install: |
|
Ok, I just timed & tested multiple ways to build several times, running Note you still need to
The native route took 1 min, 58 seconds (dependencies already manually configured before):
Depends route after the initial host configuration, 2 min, 11 seconds:
So to conclude, depends route is slightly slower for me after a |
This change is still needed to get
|
|
For the record, another reason I have never relied on depends build process, is that I could never get anything but Apple to build on a Mac. I get various failures when trying to build hosts for Windows or Linux on my Intel Mac:
Has anyone ever been able to successfully cross-compile build for Windows & Linux on a Mac? I know there is a reason the final GUIX builds happen inside a Linux Docker container, much easier cross-compilation. |
FYI all Python Functional tests pass as well. |
|
utACK |
ghost
deleted the
sqlite3 >= 3.45.2
#204
Boost >= 1.84.0
#194