Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 rpc_psbt.py Functional Tests #214

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

JaredTate
Copy link

@JaredTate JaredTate commented Mar 22, 2024

This PR fixes 2 rpc_psbt.py functional tests. This one was a pain and had to step through walletcreatefundedpsbt and used this reference to help:
https://developer.bitcoin.org/reference/rpc/walletcreatefundedpsbt.html

FYI: PSBT stands for "Partially Signed Bitcoin Transaction"... we could change name to "PSDT" but that would be a real pain throughout protocol.

To test this:

Compile:

  ./autogen.sh
  ./configure
  make -j 8

Run Specific Functional Tests

test/functional/test_runner.py rpc_psbt.py

Screenshot 2024-03-21 at 6 57 37 PM

@ycagel ycagel requested review from SmartArray, ycagel, digicontributer, gto90, j50ng and a user March 22, 2024 01:39
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! @JaredTate
Screenshot from 2024-03-22 08-06-37

Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@gto90 gto90 merged commit dd93d40 into DigiByte-Core:develop Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants