-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial wallet_basic.py Fix & 5 other Functional Test Fixes #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! @JaredTate
Same here 39 test Failed.
ACK Tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK. Excellent work @Jongjan88 and @JaredTate!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
This PR fixes 1 of 2 functional tests for wallet_basic.py and 5 other functional tests. This test wallet_basic.py is a doozy and after spending a few hours on it I figured I would share what I have done so far to see if anyone else has suggestions.
To test this:
Compile:
Run Specific Functional Tests
I am still stuck on this error for 2nd wallet_basic.py test: