-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
min_bucket_feerate 1e5 to 1000 #188
Conversation
So this is just reverting to where it was two weeks ago? Was there a specific test you found this was affecting? Looks like Lines 509 to 533 in 6723284
|
Not find a test that is effected by this yet. Maybe there is none. But i think that the max_bucket_feerate 1e10 is good and the min_bucket_feerate should be 1e3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK. Thank you @Jongjan88.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Minimum and Maximum values for tracking feerates The min_bucket_feerate should just be set to the lowest reasonable feerate we might ever want to track.
Historically this has been 1000 since it was inheriting default_min_relay_tx_fee
changing it is disruptive as it invalidates old estimates files. I think we should change it back to 1e3.
static constexpr double MIN_BUCKET_FEERATE = 1e5;
back to 1e3
static constexpr double MIN_BUCKET_FEERATE = 1000;