Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-functioning seeders and full nodes #104

Merged
merged 1 commit into from
Mar 12, 2023
Merged

Remove non-functioning seeders and full nodes #104

merged 1 commit into from
Mar 12, 2023

Conversation

saltedlolly
Copy link

@saltedlolly saltedlolly commented Feb 22, 2023

I have removed all the non-functioning seeders after testing all of them. The list is here: https://1drv.ms/w/s!AsTGLNLt5YBypgS8ljrD5-aSSqol

Many of these were not actually DNS Seeders but full nodes. Regardless, any that are no longer functioning, I have removed. The plan is to replace all the current full nodes in this list with genuine DNS Seeders, with each one run by a different member of the community, distributed around the globe. Over the last few weeks, we have been finding volunteers to do this. For better redundancy, each Seeder has a single person in charge of it, and each person may only run a single mainnet and/or testnet Seeder.

Everyone setting up a Seeder will be making their own PR to add theirs to DigiByte Core. All these will be DNS Seeders and NOT full nodes (though they can run a full node on the same server if they desire). This is the same way Bitcoin does it: https://github.com/bitcoin/bitcoin/blob/07ce278455757fb46dab95fb9b97a3f6b1b84faf/src/chainparams.cpp#L132

I have added some guidelines on how people should add their Seeder, requesting they include their name and Github handle so everyone knows who to contact in the event of a problem with the Seeder.

I have also added the testnet seeders recently set up by myself and @j50ng since none of the original testnet seeders are working anymore. This will get the testnet functioning properly again, at least for this branch. We already have two additional testnet Seeders already up and running, but they will be added in a PR from the people running them.

The new list of DigiByte Seeders (mainnet and testnet) and who is managing them can be seen here: https://1drv.ms/w/s!AsTGLNLt5YBypgadXSi16NEPaXes

We still have a few more Seeders to add around the world. If anyone can help by running one, please get in touch in the DGBCIT Telegram group: https://t.me/DGBCIT

I have removed all the non-functioning seeders after testing all of them. The list is here: https://1drv.ms/w/s!AsTGLNLt5YBypgS8ljrD5-aSSqol

Many of these were not actually DNS Seeders but full nodes. The plan is to replace all these with true DNS Seeders, with each one run by a different member of the community, distributed around the globe. Each person running a Seeder will be making their own PR to add theirs. All these should be DNS Seeders NOT full nodes. This is how Bitcoin does it: https://github.com/bitcoin/bitcoin/blob/07ce278455757fb46dab95fb9b97a3f6b1b84faf/src/chainparams.cpp#L132

I have also added some guidelines on how people should add their Seeder, including their name and Github URL so everyone knows who to contact in the event of a problem.

I have also added the testnet seeders setup by myself and @j50ng since there are none working right now. Everyone else will make their own PR to add theirs. This is simply to get the testnet working again at least for this branch.

The new list of Seeders can be seen here: https://1drv.ms/w/s!AsTGLNLt5YBypgadXSi16NEPaXes
Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to do this and test all the seeds. This looks good to me for the time being.

@JaredTate
Copy link

Copy link

@SmartArray SmartArray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @saltedlolly, especially for adding the testnet seeders. Those will be exceptionally important for future updates

Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@gto90 gto90 merged commit e9fd26d into DigiByte-Core:feature/8.22.0 Mar 12, 2023
@ghost
Copy link

ghost commented Mar 12, 2023

@JaredTate
Copy link

JaredTate commented Mar 12, 2023

Thanks!

Jongjan88

Thanks for the addition! We are about to merge the 8.22 feature branch into develop. Once that's done can you make a PR to add those? Cheers

@saltedlolly
Copy link
Author

@SmartArray There are a couple more testnet seeders already running that we will get added via a PR from the people running them. We are also looking to get a few more mainnet seeders spun up as well. I guess we should wait and make a PR to the develop branch for those, once it gets merged. It would obviously help everyone if you could fix the testnet startup bug. :)

@ycagel ycagel self-requested a review March 13, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants