Add unit tests for com.zheng.common.util.Paginator #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 30, 2019 09:55
These tests were written using Diffblue Cover.
These tests were written using Diffblue Cover.
|
Updated as per Peter's feedback:
|
petersear
suggested changes
Jul 31, 2019
| @PowerMockIgnore({"javax.management.*"}) | ||
| public class PaginatorTest { | ||
|
|
||
| /* testedClasses: Paginator */ |
|
|
||
| /* testedClasses: Paginator */ | ||
| @Test | ||
| public void initTotalPageOutputVoid() { |
There was a problem hiding this comment.
This test provides 100% coverage for the method :-)
I wonder if we could use some of the setters so that the expected value is non-zero?
| paginator.setParam(null); | ||
| paginator.setPage(0); | ||
| paginator.setTotalPage(0L); | ||
| Reflector.setField(paginator, "rows", 2); |
| InvocationTargetException { | ||
| PowerMockito.mockStatic(Math.class); | ||
| final Paginator paginator = new Paginator(); | ||
| Reflector.setField(paginator, "total", 0L); |
There was a problem hiding this comment.
We don't want to see reflection in our tests. We might be able to work around this using constructor/getters/setters.
| InvocationTargetException { | ||
| PowerMockito.mockStatic(Math.class); | ||
| final Paginator paginator = new Paginator(); | ||
| Reflector.setField(paginator, "total", 0L); |
| paginator.setParam("foo"); | ||
| paginator.setPage(0); | ||
| paginator.setTotalPage(0L); | ||
| Reflector.setField(paginator, "rows", -786_432); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've analysed your codebase and noticed that com.zheng.common.util.Paginator is not fully tested.
I've written some tests for the methods in this class with the help of Diffblue Cover.
Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important in a subsequent PR.