-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for loading config object from "<(/usr/bin/envsubst < template)" #187
base: master
Are you sure you want to change the base?
Conversation
d6e42cb
to
6d166d9
Compare
6d166d9
to
9d7a288
Compare
Co-Authored-By: Aliaksei Urbanski <[email protected]>
19db23a
to
ae4b6ab
Compare
I'm not sure why coverage dropped, but it looks like the tests work. |
Is there anything left to get this merged? |
Any update on this? |
Is it possible to get this merged? I'd like to improve the letsencrypt certbot docker container for doing dns based wildcard cert requests and this is blocking me. |
Would it help to rebase this? |
Hi, what are the security implications of these changes? How trusted are files read by configobj today? |
configobj has an issue being passed a file descriptor (/dev/fd) via process substitution.
os.path.isfile("/dev/fd/{{ anything }}")
returnsFalse
for file descriptors whileos.path.exists()
returnsTrue
.test.py
I'll update the PR with a test when I get a chance
This is needed in cloud environments where you may not want to store passwords on disk in an unencrypted form or have variables passed into a container environment.