OSI approved license required by JOSS #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can choose one from here: https://opensource.org/licenses This PR has BSD 3-clause which (like MIT and a few others) are 'permissive' - don't have restrictions like GPL family (which are also approved)
40 tasks
MIT info is in LICENSE.md
|
Dear, @dlebauer thank you for the pull request. I am confused about the LICENCE.md file and why we should delete it. Is not necessary that file? Thank you for your time. Best, Didier Murillo |
|
You have two license files with different content. LICENSE.md contains both the copyright and a copy of the the MIT License. The LICENSE file only contains the copyright information (no license). Having two files is confusing. This PR suggests deleting the LICENSE file that isn't actually a license. And then renaming LICENSE.md --> LICENSE 3720ee0 because R CMD Check failed with message "Invalid license file pointers: LICENSE" |
andyquinterom
pushed a commit
to andyquinterom/FielDHub
that referenced
this pull request
Jul 28, 2022
added heatmaps to lattice designs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can choose one from here: https://opensource.org/licensesThis PR has BSD 3-clause which (like MIT and a few others) are 'permissive' - don't have restrictions like GPL family (which are also approved)This now removes the LICENSE file that conflicts w/ LICENSE.md
result is that Github should correctly identify this as having an OSI approved license