-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tsconfig files to include JSX option #70
base: master
Are you sure you want to change the base?
Refactor tsconfig files to include JSX option #70
Conversation
apps/playground-web/tsconfig.json
Outdated
@@ -1,13 +1,16 @@ | |||
{ | |||
"extends": "@dicedb/typescript-config/nextjs.json", | |||
"compilerOptions": { | |||
"jsx": "react", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do this in typescript-config/nextjs.json
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @AjayPoshak did you mean to remove these in
-
apps/playground-web/tsconfig.json
-
packages/ui/tsconfig.json
and add here ?
- typescript-config/nextjs.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should have common config placed there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback. please check now
This pull request includes changes to the TypeScript configuration files for both the
playground-web
andui
packages. The changes primarily focus on formatting and updating compiler options to ensure consistency and compatibility with the project setup.Changes to
apps/playground-web/tsconfig.json
:jsx
compiler option set toreact
.Changes to
packages/ui/tsconfig.json
:jsx
compiler option set toreact
.