Refactor tsconfig files to include JSX option #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AjayPoshak
reviewed
Oct 15, 2024
apps/playground-web/tsconfig.json
Outdated
| @@ -1,13 +1,16 @@ | |||
| { | |||
| "extends": "@dicedb/typescript-config/nextjs.json", | |||
| "compilerOptions": { | |||
| "jsx": "react", | |||
There was a problem hiding this comment.
Can you do this in typescript-config/nextjs.json?
There was a problem hiding this comment.
Hello @AjayPoshak did you mean to remove these in
-
apps/playground-web/tsconfig.json -
packages/ui/tsconfig.json
and add here ?
- typescript-config/nextjs.json
There was a problem hiding this comment.
Yes, we should have common config placed there
There was a problem hiding this comment.
Thank you for the feedback. please check now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the TypeScript configuration files for both the
playground-webanduipackages. The changes primarily focus on formatting and updating compiler options to ensure consistency and compatibility with the project setup.Changes to
apps/playground-web/tsconfig.json:jsxcompiler option set toreact.Changes to
packages/ui/tsconfig.json:jsxcompiler option set toreact.