Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Subtitulamos provider integration #1170

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Nyaran
Copy link
Contributor

@Nyaran Nyaran commented Sep 22, 2024

Added Subtitulamos provider

This PR is partially based and replaces #826 (skipping the provider "tusubtitulo" as is not working anymore)

Also I added a way to run the cli from source code (subliminal/cli.py#L727-L728) , as is helpful to debug new additions (if you don't like it, tell me and I'll remove it)

Pending:

  • Add tests
  • Changelog entry
  • CI passes (except docs)

subliminal/cli.py Outdated Show resolved Hide resolved
@getzze
Copy link
Collaborator

getzze commented Oct 8, 2024

Thanks for updating this provider!

Don't worry too much about mypy (or if you need help let me know). It's better if coverage is high ;)

@Nyaran Nyaran marked this pull request as ready for review October 13, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants