Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mapStateToProps-prefer-selectors #50

Merged
merged 4 commits into from
Jul 13, 2020

Conversation

qjd2413
Copy link
Contributor

@qjd2413 qjd2413 commented Jul 11, 2020

Creates a rule to enforce usage of selectors in mapStateToProps.

@qjd2413
Copy link
Contributor Author

qjd2413 commented Jul 11, 2020

the build passes for node versions >= 6, and node 4/5 are failing in an external dependency. I'm guessing this is an issue with axe itself not supporting those versions?

@DianaSuvorova
Copy link
Owner

@qjd2413 thank you so much for the diff. Yes, looks like the problem with the dependency support for node version. I think they should be supporting node v4 (according to their package.json) although here they say that the min supported version is 6.

In any case let me remove v4,5 version from ci since we obviously do not support it. I will look into how and whether we need to bring it back. Looking at our sister lib - it is quite a project.

Copy link
Owner

@DianaSuvorova DianaSuvorova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the new rule! Looks great to me. Rebasing with master should fix ci failures. Please try that - if not I will take a look.

```

### `matching`
If provided, validates the name of the selector functions against the RegExp pattern provided.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to provide some examples of correct/incorrect for illustration, you have quite a few in tests.

@DianaSuvorova DianaSuvorova merged commit 6a312ab into DianaSuvorova:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants