Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include wiring for isolated components #120

Merged
merged 22 commits into from
Jun 12, 2023
Merged

Include wiring for isolated components #120

merged 22 commits into from
Jun 12, 2023

Conversation

abbiemery
Copy link
Collaborator

@abbiemery abbiemery commented Apr 14, 2023 •
edited
Loading

Fixes #96

@codecov
Copy link

codecov bot commented Apr 14, 2023 •
edited
Loading

Codecov Report

Merging #120 (0488d5d) into master (ada93e7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   92.32%   92.34%   +0.01%     
==========================================
  Files          44       44              
  Lines        1186     1189       +3     
==========================================
+ Hits         1095     1098       +3     
  Misses         91       91
Impacted Files Coverage Δ
src/tickit/core/management/event_router.py 97.80% <100.00%> (+0.07%) ⬆️

@abbiemery abbiemery marked this pull request as ready for review June 8, 2023 09:50
DiamondJoseph
DiamondJoseph requested changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what I understand of tickit, have requested some changes. Somebody with more knowledge will have to approve

@abbiemery
Copy link
Collaborator Author

I have added the extra device graphs and parameterised some of the tests as requested.

@callumforrester please may you look at this for me? I haven't parameterised all of them because it felt a bit overkill but I can do if you think I should.

Also the test file is now over 600 lines long, should we move the graph fixtures into other files?

@abbiemery abbiemery requested review from DiamondJoseph and callumforrester and removed request for DiamondJoseph and garryod June 9, 2023 11:59
callumforrester
callumforrester requested changes Jun 12, 2023
View reviewed changes
examples/devices/iobox_record.db Outdated Show resolved Hide resolved
src/tickit/core/management/event_router.py Outdated Show resolved Hide resolved
src/tickit/core/management/event_router.py Show resolved Hide resolved
examples/devices/iobox.py Outdated Show resolved Hide resolved
@abbiemery abbiemery merged commit 464663e into master Jun 12, 2023
@abbiemery abbiemery deleted the 96_isolated_components branch June 12, 2023 14:03
@callumforrester callumforrester mentioned this pull request Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garryod garryod garryod left review comments

@DiamondJoseph DiamondJoseph DiamondJoseph approved these changes

@callumforrester callumforrester callumforrester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Disjoining Components
4 participants
@abbiemery @callumforrester @DiamondJoseph @garryod