Fix eiger stream #104
Merged
Fix eiger stream #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumforrester
approved these changes
Mar 12, 2024
GDYendell
force-pushed
the
fix-eiger-stream
branch
from
2d4d73a
to
7f13b57
Compare
abbiemery
approved these changes
Aug 22, 2024
GDYendell
force-pushed
the
fix-formatting
branch
from
f8ed1a8
to
98364cc
Compare
GDYendell
force-pushed
the
fix-eiger-stream
branch
from
7f13b57
to
9118017
Compare
GDYendell
force-pushed
the
fix-eiger-stream
branch
from
9118017
to
00b424c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 34 34
Lines 1620 1620
=======================================
Hits 1528 1528
Misses 92 92 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently these parameters are floats, which makes the frameReceiver crash when trying to parse simulated data. This changes the parameters to be ints as they should be.
Fixes #94