This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Remove MXSC (edge detection) AD plugin device #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -175,7 +167,6 @@ def offset_and_move(tip: Pixel): | |||
| yield from bps.sleep(0.3) | |||
|
|
|||
| # Set up the old pin tip centring as we will need it for grid detection. Remove once #1068 is done | |||
There was a problem hiding this comment.
We can remove this comment now
olliesilvester
approved these changes
Mar 27, 2024
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/1219_remove_mxsc Remove MXSC (edge detection) AD plugin device
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1219
Dodal PR: DiamondLightSource/dodal#390
Updates the tests to work with the new pin tip device, and removes the ability to choose between the two devices.
Bumps param version to 4.0.5 - Will require a GDA change to bump param version and remove the
use_ophyd_edge_detectparam.To test: