-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
378 Convert source tree to python-copier-template #667
Conversation
a13bbe1
to
dfe4e6a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
+ Coverage 93.55% 94.17% +0.61%
==========================================
Files 105 108 +3
Lines 4114 4306 +192
==========================================
+ Hits 3849 4055 +206
+ Misses 265 251 -14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks fine, probably too complicated to inspect every individual line - since warnings are now errors I can only assume things are on average better than they were
from dodal import __version__ | ||
|
||
|
||
@pytest.mark.skip_in_pycharm(reason="subprocess returns tty escape sequences") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:(
…ssing pyright plugin to dependencies
7cb0857
to
8066200
Compare
* (#378) Initial changes for copier template v1.0.0 * (#378) More sensible pre-commit defaults. Fix some broken unit tests * (#378) unit tests mostly working * Add Pycharm project files to .gitignore * (#378) Update to version v2.1.0 of copier template from v1.0.0 * (#378) minor fixes to documentation generation * (#378) Enable pypi publishing * (#378) Update software catalog info * (#378) Rebase onto latest main * (#378) Use diff-quality rather than pyright, make pyright, ruff happy * (#378) Make ruff happy, and code less evil. Add diff-cover to dependencies * (#378) Fix test failures due to missing decorator parentheses. Add missing pyright plugin to dependencies * (#378) Set fetch-depth to 0 for diff-quality * (#378) Fix dist CI * (#378) fix tests, ruff after rebase against main * (#378) Add warning suppression to unit tests for pydantic v2
This moves the project to the
python-copier-template
project styleFixes #378
Notes
Documentation
user
anddeveloper
sections. This is probably a good move for dodal as the distinction between users and developers is somewhat blurred anyway. I have attempted to retain customisation of the documentation where appropriate.Development environment
CI
_
called from the main workflows.await
ed and outlived the lifespan of the testpyproject.toml
pyproject.toml
which add various additional checksDependencies
python-copier-template
has a dependency onpydantic
>= 2.0 which conflicts with the rest of dodal dependencies so cannot be included in the list of development dependencies; you have to uninstall it after running itDeveloper Portal
https://dev-portal.diamond.ac.uk
TODO
Checks for reviewer
dodal connect ${BEAMLINE}