Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilise Aravis implementation from ophyd-async 0.3a3 #500

Merged
merged 4 commits into from
May 3, 2024
Merged

Utilise Aravis implementation from ophyd-async 0.3a3 #500

merged 4 commits into from
May 3, 2024

Conversation

DiamondJoseph
Copy link
Contributor

Fixes #406

Adds an Aravis as the OAV for i22, for the p38/p45 test beamlines.

Instructions to reviewer on how to test:

  1. Test that Aravis detector can be instantiated in dummy mode and the signals look correct to connect to the actual instances

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards

@DiamondJoseph DiamondJoseph marked this pull request as ready for review May 3, 2024 14:09
@DiamondJoseph DiamondJoseph merged commit 3c0de85 into main May 3, 2024
11 checks passed
@DiamondJoseph DiamondJoseph deleted the aravis branch May 3, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callumforrester callumforrester callumforrester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust and merge i22 Pilatus Ophyd Async device
2 participants
@DiamondJoseph @callumforrester