Make the PinTipDetection device also store top and bottom edges #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2024
dperl-dls
force-pushed
the
hyperion_1068_1213_ophyd_oav_for_grid_detect
branch
from
6f0c355
to
c193fc1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
==========================================
+ Coverage 93.28% 93.30% +0.01%
==========================================
Files 85 85
Lines 3290 3299 +9
==========================================
+ Hits 3069 3078 +9
Misses 221 221 ☔ View full report in Codecov by Sentry. |
DominicOram
requested changes
Mar 5, 2024
Comment on lines
98
to
100
| async def _set_edges(self, values: tuple[NDArray, NDArray]): | ||
| await self.triggered_top_edge._backend.put(values[0]) | ||
| await self.triggered_bottom_edge._backend.put(values[1]) |
There was a problem hiding this comment.
Could: Feels like we can just have one _set_triggered_values function that takes a SampleLocation rather than this split
….com:DiamondLightSource/dodal into hyperion_1068_1213_ophyd_oav_for_grid_detect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for hyperion DiamondLightSource/hyperion#1213 DiamondLightSource/hyperion#1068
Instructions to reviewer on how to test:
Checks for reviewer