Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create FastAPI app until config loaded #702

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

DiamondJoseph
Copy link
Contributor

@DiamondJoseph DiamondJoseph commented Nov 7, 2024

Defers creation of the FastAPI app, which will allow configuration to be loaded first.
This will allow us to e.g. configure authentication prior to starting the app.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.32%. Comparing base (1c50a4b) to head (1ed5c2e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/blueapi/service/main.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   92.35%   92.32%   -0.04%     
==========================================
  Files          35       35              
  Lines        1793     1799       +6     
==========================================
+ Hits         1656     1661       +5     
- Misses        137      138       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DiamondJoseph DiamondJoseph force-pushed the detach-app branch 2 times, most recently from 8149a08 to e581c27 Compare November 7, 2024 15:17
src/blueapi/service/main.py Show resolved Hide resolved
@DiamondJoseph DiamondJoseph merged commit 00572da into main Nov 8, 2024
28 checks passed
@DiamondJoseph DiamondJoseph deleted the detach-app branch November 8, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants