Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make helm chart job only run if container is built ok #667

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make helm chart job only run if container is built ok #667

wants to merge 2 commits into from

Conversation

stan-dot
Copy link
Collaborator

Fixes #136

@stan-dot stan-dot added bug Something isn't working enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Oct 11, 2024
@stan-dot stan-dot self-assigned this Oct 11, 2024
@stan-dot stan-dot linked an issue Oct 11, 2024 that may be closed by this pull request
CI: Helm chart should not be created if the container creation fails #136
Open
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.56%. Comparing base (ac0fee8) to head (dc0709f).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   92.56%   92.56%           
=======================================
  Files          35       35           
  Lines        1654     1654           
=======================================
  Hits         1531     1531           
  Misses        123      123

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stan-dot
Copy link
Collaborator Author

that is the culprit - might need to solve both issues in one go for this to pass
#411

@callumforrester
Copy link
Collaborator

Please give this PR a sensible title

@stan-dot stan-dot changed the title try out by adding the needs field Make helm chart job only run if container is built ok Oct 14, 2024
@stan-dot stan-dot force-pushed the 136-ci-helm-chart-should-not-be-created-if-the-container-creation-fails branch from 62b1bb7 to dc0709f Compare October 16, 2024 13:48
@stan-dot stan-dot marked this pull request as ready for review October 16, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callumforrester callumforrester Awaiting requested review from callumforrester

@DiamondJoseph DiamondJoseph Awaiting requested review from DiamondJoseph

@abbiemery abbiemery Awaiting requested review from abbiemery

@dan-fernandes dan-fernandes Awaiting requested review from dan-fernandes

At least 1 approving review is required to merge this pull request.

Assignees

@stan-dot stan-dot

Labels
bug Something isn't working enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Helm chart should not be created if the container creation fails
2 participants
@stan-dot @callumforrester