Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codeql config #596

Merged
merged 1 commit into from
Sep 9, 2024
Merged

add codeql config #596

merged 1 commit into from
Sep 9, 2024

Conversation

stan-dot
Copy link
Contributor

No description provided.

@stan-dot stan-dot added enhancement New feature or request github_actions Pull requests that update GitHub Actions code tests Issues around increasing test coverage/fixing tests labels Aug 20, 2024
@stan-dot stan-dot self-assigned this Aug 20, 2024
@stan-dot stan-dot linked an issue Aug 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (ec13eac) to head (f73c12c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #596   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          35       35           
  Lines        1632     1632           
=======================================
  Hits         1510     1510           
  Misses        122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@stan-dot stan-dot marked this pull request as ready for review August 22, 2024 15:13
@stan-dot stan-dot force-pushed the 595-configure-codeql-and-sonarcloud branch from 085914e to 5f1ba8e Compare August 22, 2024 15:13
@stan-dot
Copy link
Contributor Author

  Downloading PyYAML-5.4.1.tar.gz (175 kB)
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [48 lines of output]
      running egg_info
      writing lib3/PyYAML.egg-info/PKG-INFO```
      
      that's the weirdest error, I re-ran the script and it persisted
      
@callumforrester any tips how to solve this?

@stan-dot
Copy link
Contributor Author

fwiw the main branch suffers from the same issue
https://github.com/DiamondLightSource/blueapi/actions/runs/10580495453/job/29315513545

@stan-dot
Copy link
Contributor Author

@stan-dot stan-dot mentioned this pull request Aug 28, 2024
@stan-dot stan-dot force-pushed the 595-configure-codeql-and-sonarcloud branch from 5f1ba8e to 50dc877 Compare August 29, 2024 14:30
@stan-dot stan-dot force-pushed the 595-configure-codeql-and-sonarcloud branch from 50dc877 to 2bc9c06 Compare August 30, 2024 15:49
Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stan-dot stan-dot force-pushed the 595-configure-codeql-and-sonarcloud branch from 0fdd9e1 to f73c12c Compare September 9, 2024 09:30
@stan-dot stan-dot merged commit 09f65fe into main Sep 9, 2024
26 checks passed
@stan-dot stan-dot deleted the 595-configure-codeql-and-sonarcloud branch September 9, 2024 09:48
@stan-dot stan-dot restored the 595-configure-codeql-and-sonarcloud branch September 9, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code tests Issues around increasing test coverage/fixing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure CodeQL and sonarcloud
2 participants