-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create very simple RPC so the subprocess loads functions #584
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 92.86% 92.84% -0.02%
==========================================
Files 40 40
Lines 1793 1818 +25
==========================================
+ Hits 1665 1688 +23
- Misses 128 130 +2 ☔ View full report in Codecov by Sentry. |
1a41a5f
to
5f3b48d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for the _rpc function, if @callumforrester can approve for the other changes I made ;)
Is there an associated issue for this? I can't quite infer what the problem was from this PR. Presumably pickle related? |
I assume so from Callum's first commit (but surely still has to pickle the args, kwargs just not the function?), my interest in it is it makes upcoming observability handling easier |
I've made a retroactive issue: #590 |
Co-authored-by: Callum Forrester <[email protected]>
b03defb
to
b47fef8
Compare
Fixes #590