Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make environment error message be a non-empty string or None #571

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

callumforrester
Copy link
Contributor

The code was using None or "" in various places to denote the lack of an error message. None is a better semantic fit, so this PR forces the user to pass either None or a string with at least 1 character.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (3461bcc) to head (d8c1829).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   90.21%   90.21%           
=======================================
  Files          41       41           
  Lines        1829     1829           
=======================================
  Hits         1650     1650           
  Misses        179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joeshannon joeshannon merged commit 06988d1 into main Jul 26, 2024
24 checks passed
@joeshannon joeshannon deleted the fix-env-model branch July 26, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants