Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct generated schema for Reference types #522

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Correct generated schema for Reference types #522

merged 3 commits into from
Jun 25, 2024

Commits on Jun 25, 2024

  1. Correct generated schema for Reference types 

    When bluesky protocol types are translated into references to allow them
to be passed by name from external processes, the generated schema needs
to specify the type that the reference should refer to rather than the
type of the value itself (str).

The previous version used the field name as the key for this entry in
the schema instead of the constant 'type' used and expected elsewhere.
    @tpoliaw
    tpoliaw committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    34543d5 View commit details
    Browse the repository at this point in the history

  2. Add test for generated schema

    @tpoliaw
    tpoliaw committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2f08d79 View commit details
    Browse the repository at this point in the history

  3. Use FQCN for reference type schemas 

    Instead of using the repr(cls) output. Gives

    bluesky.protocols.Readable

instead of

    <class 'bluesky.protocols.Readable'>
    @tpoliaw
    tpoliaw committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    46598b0 View commit details
    Browse the repository at this point in the history