Automatically init scratch area and remove startup script #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need testing on k8s |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
+ Coverage 91.32% 91.51% +0.18%
==========================================
Files 41 42 +1
Lines 1880 1933 +53
==========================================
+ Hits 1717 1769 +52
- Misses 163 164 +1 ☔ View full report in Codecov by Sentry. |
callumforrester
commented
Jun 24, 2024
| {{- if .Values.scratch.hostPath }} | ||
| - name: init-venv | ||
| image: busybox:1.28 | ||
| command: ['sh', '-c', "cp -r /venv /emptyDir/venv"] |
There was a problem hiding this comment.
My current concern with this is the added startup time
joeshannon
reviewed
Jun 24, 2024
joeshannon
reviewed
Jun 24, 2024
joeshannon
reviewed
Jun 24, 2024
callumforrester
force-pushed
the
init-scratch
branch
4 times, most recently
from
351c8bc
to
376561e
Compare
|
Still to do:
|
callumforrester
force-pushed
the
init-scratch
branch
from
1f19820
to
18e5cda
Compare
joeshannon
reviewed
Jul 10, 2024
Co-authored-by: Joe Shannon <[email protected]>
Co-authored-by: Joe Shannon <[email protected]>
callumforrester
force-pushed
the
init-scratch
branch
from
b2b2f94
to
3783354
Compare
joeshannon
approved these changes
Jul 10, 2024
This was referenced Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #510 and #399
Write python code to do the job of
container-startup.shand add code to clone the required repos. Replacecontainer-startup.shwith this code. Stop blueapi from initializing scratch automatically on container startup, replace this job with an initContainer. Copy the blueapi venv to an emptyDir so the initContainers can manipulate it.