-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply the error message cleaning patch onto a fresh branch #473
Apply the error message cleaning patch onto a fresh branch #473
Conversation
@stan-dot the PR title/description will become a commit message, please can you make them more informative? |
I mean I put a commit name and only then it became a PR name. I thought that the commit names get squashed anyway |
I was wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
(just need to make the tests pass)
46adc00
to
30e29c8
Compare
ok it does not make sense to validate that 'the wrong plan gets rejected', as that is not a responsibility of CLI |
@callumforrester so locally I can start but then the values are discordant. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
- Coverage 91.06% 90.43% -0.63%
==========================================
Files 40 40
Lines 1667 1694 +27
==========================================
+ Hits 1518 1532 +14
- Misses 149 162 +13 ☔ View full report in Codecov by Sentry. |
No description provided.