Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the error message cleaning patch onto a fresh branch #473

Merged

Conversation

stan-dot
Copy link
Contributor

No description provided.

@stan-dot stan-dot linked an issue May 20, 2024 that may be closed by this pull request
@stan-dot stan-dot self-assigned this May 20, 2024
@callumforrester
Copy link
Contributor

@stan-dot the PR title/description will become a commit message, please can you make them more informative?

@stan-dot stan-dot changed the title apply changes again clean Apply the error message cleaning patch onto a fresh branch May 20, 2024
@stan-dot
Copy link
Contributor Author

I mean I put a commit name and only then it became a PR name. I thought that the commit names get squashed anyway

@stan-dot
Copy link
Contributor Author

I was wrong

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks
(just need to make the tests pass)

@stan-dot stan-dot marked this pull request as draft May 21, 2024 14:28
@stan-dot stan-dot force-pushed the 206-unclear-error-message-when-running-plan-without-parameters-1 branch from 46adc00 to 30e29c8 Compare May 28, 2024 15:25
@stan-dot
Copy link
Contributor Author

ok it does not make sense to validate that 'the wrong plan gets rejected', as that is not a responsibility of CLI

@stan-dot
Copy link
Contributor Author

@callumforrester so locally I can start blueapi serve without example config. but then it is necessary for running the controller.

but then the values are discordant.

when I try to run blueapi serve with the file, I get:
image

@stan-dot stan-dot marked this pull request as ready for review May 28, 2024 16:26
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 90.43%. Comparing base (6f08f68) to head (48d3d04).

Files Patch % Lines
src/blueapi/cli/rest.py 20.00% 8 Missing ⚠️
src/blueapi/cli/cli.py 63.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   91.06%   90.43%   -0.63%     
==========================================
  Files          40       40              
  Lines        1667     1694      +27     
==========================================
+ Hits         1518     1532      +14     
- Misses        149      162      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stan-dot stan-dot merged commit dbe9634 into main May 30, 2024
45 of 46 checks passed
@DiamondJoseph DiamondJoseph deleted the 206-unclear-error-message-when-running-plan-without-parameters-1 branch September 5, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear error message when running plan without parameters
2 participants