added indexing to handle tuple #468
Conversation
|
The tests are failing now because it is testing it with the old version of dodal |
src/blueapi/core/context.py
Outdated
| for device in devices.values(): | ||
| self.device(device) | ||
|
|
||
| num_failed = len(exceptions) |
There was a problem hiding this comment.
Should we register devices that had exceptions?
There was a problem hiding this comment.
exceptions is literally a dictionary of str -> Exception rather than str -> Device. There is nothing to register.
There was a problem hiding this comment.
Has the signature of make_all_devices changed? Seems it used to return dict[str, Device] but now returns tuple[dict[str, Device], dict[str, Exception]]?
There was a problem hiding this comment.
It changes in the corresponding dodal PR, see description: DiamondLightSource/dodal#550
callumforrester
force-pushed
the
connection-resilience
branch
from
da28b14
to
d2ecd6e
Compare
|
Tests will pass following a dodal release |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
==========================================
+ Coverage 90.43% 90.46% +0.02%
==========================================
Files 40 40
Lines 1694 1699 +5
==========================================
+ Hits 1532 1537 +5
Misses 162 162 ☔ View full report in Codecov by Sentry. |
src/blueapi/core/context.py
Outdated
| # If exceptions have occurred, we log them but we do not make blueapi | ||
| # fall over | ||
| if len(exceptions) > 0: | ||
| LOGGER.warning(f"{len(exceptions)} device(s) failed to connect") |
There was a problem hiding this comment.
nit:
| LOGGER.warning(f"{len(exceptions)} device(s) failed to connect") | |
| LOGGER.warning(f"{len(exceptions)} exceptions while attempting to connect") |
As discussed, any Errors from method signatures also get inserted
callumforrester
force-pushed
the
connection-resilience
branch
from
2aab175
to
b695858
Compare
closes #444
With PR for dodal at DiamondLightSource/dodal#550