-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install git in runtime container #446
Conversation
5168e69
to
c945816
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage 90.16% 90.16%
=======================================
Files 41 41
Lines 1708 1708
=======================================
Hits 1540 1540
Misses 168 168 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should work, I did look in the action logs though and it wasn't clear where git was being installed.
Also the apt
in the container above has && rm -rf /var/lib/apt/lists/*
at the end of it - do we really need this here too?
It was being installed but I missed it before as it seemed to be building the runtime container in parallel with the developer container. |
The copier template has @coretl @gilesknap Is this some sort of best practice for using apt in Dockerfiles? Should I include it here too? |
Yes, reading the docker best practices you get examples that look like that: |
This is required for installing python packages at runtime. It was previously present in the non-slim python container used before but this was accidentally removed with the switch to the copier template. Fixes #445.
c945816
to
2385dd5
Compare
Thanks! |
This is required for installing python packages at runtime. It was previously present in the non-slim python container used before but this was accidentally removed with the switch to the copier template. Fixes #445.
This is required for installing python packages at runtime.
It was previously present in the non-slim python container used before but this was accidentally removed with the switch to the copier template.
Fixes #445.