Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renumber adrs #417

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Renumber adrs #417

merged 1 commit into from
Apr 12, 2024

Conversation

joeshannon
Copy link
Contributor

No description provided.

Following on from discussion at:
DiamondLightSource/python-copier-template#136

Specifically, ADRs 0001 & 0002 will remain static in the
python-copier-template and no further ADRs will be added to the
template.

This will ensure there are no conflicts going forward with future
template updates.
@joeshannon joeshannon marked this pull request as ready for review April 12, 2024 13:13
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (2827230) to head (50ef707).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #417   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files          43       43           
  Lines        1800     1800           
=======================================
  Hits         1609     1609           
  Misses        191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joeshannon joeshannon merged commit d1bd4c2 into main Apr 12, 2024
24 checks passed
@joeshannon joeshannon deleted the renumber-adrs branch April 12, 2024 13:23
ZohebShaikh pushed a commit that referenced this pull request May 7, 2024
Following on from discussion at:
DiamondLightSource/python-copier-template#136

Specifically, ADRs 0001 & 0002 will remain static in the
python-copier-template and no further ADRs will be added to the
template.

This will ensure there are no conflicts going forward with future
template updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants