Allow passing kwargs to make_all_devices for dodal modules #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #304 +/- ##
=======================================
Coverage 88.99% 88.99%
=======================================
Files 38 38
Lines 1390 1390
=======================================
Hits 1237 1237
Misses 153 153
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
callumforrester
approved these changes
Sep 8, 2023
Tom-Willemsen
added a commit
that referenced
this pull request
Nov 7, 2023
…330) Functionality added in #304 and [being used in hyperion](https://github.com/DiamondLightSource/hyperion/blob/92b23dac5efc1aa78910d2f0f4bd28725a9ec836/src/hyperion/utils/context.py#L81) got removed in 076da45 . It doesn't look like there was a clear reason for this removal of functionality so I think it should be reinstated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, in hyperion it would be useful to be able to pass through
wait_for_connectionandfake_with_ophyd_sim- but keeping this generic to anykwarg(likemake_all_devicesitself) seems nicer than restricting it to just those two.