Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CLI to blueapi and deprecate old one #163

Merged
merged 3 commits into from
May 3, 2023
Merged

Conversation

callumforrester
Copy link
Contributor

From discussion with @joeshannon, it's probably best if the old CLI command bluesky goes away to be replaced with blueapi to avoid confusion.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #163 (ee68030) into main (bcfabb7) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   74.47%   74.62%   +0.14%     
==========================================
  Files          37       38       +1     
  Lines        1050     1056       +6     
==========================================
+ Hits          782      788       +6     
  Misses        268      268              
Impacted Files Coverage Δ
src/blueapi/cli/_deprecated.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do we have a deprecation cycle? Would be nice to formalise something early

@callumforrester
Copy link
Contributor Author

Hmm, good question. We don't have a formal release cycle yet. Could be time-based?

@callumforrester callumforrester marked this pull request as ready for review May 3, 2023 08:13
@callumforrester
Copy link
Contributor Author

Have decided for this particular case it will be 1 sprint: #164
We should think about a more general approach.

@callumforrester callumforrester merged commit 28042db into main May 3, 2023
@callumforrester callumforrester deleted the rename-cli branch May 3, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants