Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract message definitions in schema to allow referencing from other APIs #160

Merged
merged 8 commits into from
May 3, 2023

Conversation

DiamondJoseph
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #160 (10082ce) into main (bcfabb7) will increase coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 10082ce differs from pull request most recent head 15cc499. Consider uploading reports for the commit 15cc499 to get more accurate results

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   74.47%   74.62%   +0.14%     
==========================================
  Files          37       38       +1     
  Lines        1050     1056       +6     
==========================================
+ Hits          782      788       +6     
  Misses        268      268              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DiamondJoseph
Copy link
Contributor Author

Have made a pull request with the updated AsyncAPI parser to try and get the github action enabled, but will disable for now.

Copy link
Contributor

@keithralphs keithralphs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer CI job was deleted and put in an issue

@DiamondJoseph DiamondJoseph merged commit a90f03f into DiamondLightSource:main May 3, 2023
@DiamondJoseph DiamondJoseph deleted the schema branch May 12, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants