Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Devices in Parameter Serialization #50

Closed
callumforrester opened this issue Oct 10, 2022 · 0 comments · Fixed by #125
Closed

Handle Devices in Parameter Serialization #50

callumforrester opened this issue Oct 10, 2022 · 0 comments · Fixed by #125
Assignees
@callumforrester
Labels
enhancement New feature or request

Comments

@callumforrester
Copy link
Contributor

Currently, the worker serializes plan parameters and includes them in WorkerEvents, which it publishes to the message bus.
This can present problems if the parameters are of complex types e.g. devices.

Two options that I can think of:

  • Exclude plan parameters from events
  • Find some way to have default serializes, if an object has a name, use that, otherwise serialize to "UNKNOWN" or similar
@callumforrester callumforrester added the enhancement New feature or request label Oct 10, 2022
@callumforrester callumforrester added this to the Error Handling/Recovery milestone Oct 10, 2022
@callumforrester callumforrester self-assigned this Oct 10, 2022
@callumforrester callumforrester mentioned this issue Nov 16, 2022
Merged
@DiamondJoseph DiamondJoseph mentioned this issue Apr 18, 2023
Merged
DiamondJoseph added a commit that referenced this issue Apr 19, 2023
@DiamondJoseph
Merge pull request #125 from DiamondJoseph/DAQ-4640
9e40b28 
Add repr of ScanSpec to Scan Plan metadata and add tests for #50 resolution
keithralphs pushed a commit that referenced this issue Apr 28, 2023
@DiamondJoseph @keithralphs
Add repr of ScanSpec to Scan Plan metadata and add tests to prove #50 …
3cd00bf 
…is resolved

Resolves #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@callumforrester callumforrester

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add repr of ScanSpec to Scan Plan metadata and add tests for #50 resolution
1 participant
@callumforrester