Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt copier template #52

Merged
merged 8 commits into from
Oct 10, 2024
Merged

Conversation

AlexanderWells-diamond
Copy link
Contributor

A fair amount of manual work went in to fixing the Docs, to make the existing .rst work with the new .md format. The new documentation should be reviewed to check it is sensible.

Using default Sphinx documentation layout.
Added MacOS and Windows to default CI.
Made some changes to Ruff configuration as it seems the template is
out of date.
Includes work to make old .rst docs work with .md format
Includes a fix in conf.py for broken autodoc_type_aliases
Copy link

codecov bot commented Oct 8, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Also fixes the trivial changes that these changes highlight.
Note there are more complex linting errors spotted...
It's useful purely for the --version check in CI.
@AlexanderWells-diamond
Copy link
Contributor Author

@coretl The remaining errors are a handful of new linting errors, and a single test failure.

The linting errors are mostly regarding accessing private members, which would require actual code changes to fix.

The one test failure is strange - it's completely repeatable, but only after the copier template has been applied. I can't see any obvious packages that would cause it (I tried rolling back epicscorelibs and various pytest-* dependencies). It passed here a few months ago.

How do you want me to handle these issues?

I think this failure starts in Python3.8 due to changes in unraiseable
exception behaviour, or possibly in how pytest
handles them. See `sys.unraisablehook`.
@AlexanderWells-diamond
Copy link
Contributor Author

After discussion with @coretl I mostly ignored the linting errors, and then spent some time investigating the test failure and applying a (hacky) fix to it. This is now ready for review.

.copier-answers.yml Outdated Show resolved Hide resolved
catalog-info.yaml Outdated Show resolved Hide resolved
src/aioca/__main__.py Show resolved Hide resolved
@AlexanderWells-diamond AlexanderWells-diamond merged commit 2ff5a6b into master Oct 10, 2024
31 checks passed
@AlexanderWells-diamond AlexanderWells-diamond deleted the adopt_copier_template branch October 10, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants