Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using .crop doesn't work corectly #32

Closed
DevTard opened this issue Sep 20, 2019 · 5 comments
Closed

using .crop doesn't work corectly #32

DevTard opened this issue Sep 20, 2019 · 5 comments
Milestone

Comments

@DevTard
Copy link

DevTard commented Sep 20, 2019

When using .crop, it opens the camera, when you take a picture it opens the crop screen and opens the camera again.

@stanislavmilev5
Copy link

I have the same issue, can you please provide a fix

@vitorhugods
Copy link

This seems to be device dependent. Or more specifically, dependent on the Camera App.
It is happening to me as well in the Android Emulator (29.3.7), but it does not happen on my LG G8S.

@vitorhugods
Copy link

vitorhugods commented Feb 27, 2020

After further investigation:

It only happens in some devices (maybe it is Android 10+ related), and only when using InlineActivityResult.

I replaced InlineActivityResult with the old-fashioned approach, and it worked flawlessly.

I think this issue should be renamed, as it isn't .crop() related.

@Dhaval2404
Copy link
Owner

Dhaval2404 commented Apr 11, 2020

The issue is in InlineActivityResult lib. I have submitted a [pull request (https://github.com/florent37/InlineActivityResult/pull/13), Which is recently merged in their master branch. Now, Waiting for the new release.

Dhaval2404 added a commit that referenced this issue May 4, 2020
Replace InlineActivityResult with ActivityResultContract

#32 #78
@Dhaval2404 Dhaval2404 added this to the v1.8 milestone May 4, 2020
Dhaval2404 added a commit that referenced this issue Jul 12, 2020
Update inline-activity-result to v1.0.4

#32 #92
@Dhaval2404
Copy link
Owner

Pull Request has been merged, So upgrading Gradle for the fixes.

@Dhaval2404 Dhaval2404 reopened this Jul 12, 2020
@Dhaval2404 Dhaval2404 modified the milestones: v1.8, v1.7.2 Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants