Avoid potentially unsupported PSR-16 cache keys

Ensure compatibility with all PSR-16 cache implementation by using a stricter character set for cache key that match the spec. Fixes PHPOffice#354
Dfred · Oct 29, 2018 · ba29811 · ba29811
1 parent 81258ef
commit ba29811
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [Unreleased]
+
+### Fixed
+
+- Avoid potentially unsupported PSR-16 cache keys - [#354](https://github.com/PHPOffice/PhpSpreadsheet/issues/354) 
+
 ## [1.1.0] - 2018-01-28
 
 ### Added

diff --git a/src/PhpSpreadsheet/Collection/Cells.php b/src/PhpSpreadsheet/Collection/Cells.php
@@ -285,7 +285,7 @@ public function getHighestRow($column = null)
      */
     private function getUniqueID()
     {
-        return uniqid('phpspreadsheet-', true) . '-';
+        return uniqid('phpspreadsheet.', true) . '.';
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -285,7 +285,7 @@ public function getHighestRow($column = null) @@
          */
         private function getUniqueID()
         {
-            return uniqid('phpspreadsheet-', true) . '-';
+            return uniqid('phpspreadsheet.', true) . '.';
         }
         /**
@@ Expand Down @@