Rename tests according to the class the class they are testing

Dfred · Oct 29, 2018 · 85096dd · 85096dd
1 parent 6f30555
commit 85096dd
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 37 deletions.
diff --git a/tests/PhpSpreadsheetTests/SampleTest.php → ...PhpSpreadsheetTests/Helper/SampleTest.php b/tests/PhpSpreadsheetTests/SampleTest.php → ...PhpSpreadsheetTests/Helper/SampleTest.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace PhpOffice\PhpSpreadsheetTests;
+namespace PhpOffice\PhpSpreadsheetTests\Sample;
 
 use PhpOffice\PhpSpreadsheet\Helper\Sample;
 use PHPUnit_Framework_TestCase;

diff --git a/...s/PhpSpreadsheetTests/Reader/HTMLTest.php → ...s/PhpSpreadsheetTests/Reader/HtmlTest.php b/...s/PhpSpreadsheetTests/Reader/HTMLTest.php → ...s/PhpSpreadsheetTests/Reader/HtmlTest.php
@@ -5,7 +5,7 @@
 use PhpOffice\PhpSpreadsheet\Reader\Html;
 use PHPUnit_Framework_TestCase;
 
-class HTMLTest extends PHPUnit_Framework_TestCase
+class HtmlTest extends PHPUnit_Framework_TestCase
 {
     public function testCsvWithAngleBracket()
     {

diff --git a/...s/PhpSpreadsheetTests/Reader/XLSXTest.php → ...s/PhpSpreadsheetTests/Reader/XlsxTest.php b/...s/PhpSpreadsheetTests/Reader/XLSXTest.php → ...s/PhpSpreadsheetTests/Reader/XlsxTest.php
@@ -5,7 +5,7 @@
 use PhpOffice\PhpSpreadsheet\Reader\Xlsx;
 use PHPUnit_Framework_TestCase;
 
-class XLSXTest extends PHPUnit_Framework_TestCase
+class XlsxTest extends PHPUnit_Framework_TestCase
 {
     /**
      * Test load Xlsx file without cell reference.

diff --git a/tests/PhpSpreadsheetTests/Style/NumberFormatDateTest.php b/tests/PhpSpreadsheetTests/Style/NumberFormatDateTest.php
diff --git a/tests/PhpSpreadsheetTests/Style/NumberFormatTest.php b/tests/PhpSpreadsheetTests/Style/NumberFormatTest.php
@@ -29,4 +29,20 @@ public function providerNumberFormat()
     {
         return require 'data/Style/NumberFormat.php';
     }
+
+    /**
+     * @dataProvider providerNumberFormatDates
+     *
+     * @param mixed $expectedResult
+     */
+    public function testFormatValueWithMaskDate($expectedResult, ...$args)
+    {
+        $result = NumberFormat::toFormattedString(...$args);
+        self::assertEquals($expectedResult, $result);
+    }
+
+    public function providerNumberFormatDates()
+    {
+        return require 'data/Style/NumberFormatDates.php';
+    }
 }
diff --git a/...etTests/Worksheet/WorksheetColumnTest.php → ...SpreadsheetTests/Worksheet/ColumnTest.php b/...etTests/Worksheet/WorksheetColumnTest.php → ...SpreadsheetTests/Worksheet/ColumnTest.php
@@ -7,7 +7,7 @@
 use PhpOffice\PhpSpreadsheet\Worksheet\Worksheet;
 use PHPUnit_Framework_TestCase;
 
-class WorksheetColumnTest extends PHPUnit_Framework_TestCase
+class ColumnTest extends PHPUnit_Framework_TestCase
 {
     public $mockWorksheet;
     public $mockColumn;

diff --git a/...sheetTests/Worksheet/WorksheetRowTest.php → ...PhpSpreadsheetTests/Worksheet/RowTest.php b/...sheetTests/Worksheet/WorksheetRowTest.php → ...PhpSpreadsheetTests/Worksheet/RowTest.php
@@ -7,7 +7,7 @@
 use PhpOffice\PhpSpreadsheet\Worksheet\Worksheet;
 use PHPUnit_Framework_TestCase;
 
-class WorksheetRowTest extends PHPUnit_Framework_TestCase
+class RowTest extends PHPUnit_Framework_TestCase
 {
     public $mockWorksheet;
     public $mockRow;