modify ebs encryption logic #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoungJinJung
requested review from
GwonsooLee,
jupitersong and
asbubam
as code owners
YoungJinJung
force-pushed
the
fix/modify-ebs-encryption
branch
from
6b3a742 to
b37041b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs
Description
When provisioning ec2, the function to encrypt ebs has been modified.
By default, encrypted: true and when there is no kmsAlias, it is encrypted with alias/aws/ebs, and when kmsAlias is specified, it is encrypted with the corresponding kms key.
A policy that ListAlias the IAM Role used when deploying is required.
User facing changes (remove if N/A)
Follow-up Work (remove if N/A)