Skip to content

Commit

Permalink
Remove the TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
brimworks committed Mar 23, 2023
1 parent fb86121 commit 1b2f863
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions picky-asn1/src/wrapper.rs
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,6 @@ impl IntegerAsn1 {
}
}

// TODO: This method should probably take a `&[u8]`:
pub fn from_bytes_be_signed(bytes: Vec<u8>) -> Self {
let start = minimal_encode_start(&bytes);
if start == 0 {
Expand All @@ -410,7 +409,6 @@ impl IntegerAsn1 {
/// and add a leading 0x00 byte indicating the number is positive.
/// Prefer `from_signed_bytes_be` if you can build a signed bytes string without
/// overhead on you side.
// TODO: This method should probably take a `&[u8]`:
pub fn from_bytes_be_unsigned(mut bytes: Vec<u8>) -> Self {
if !bytes.is_empty() && bytes[0] & 0x80 == 0x80 {
bytes.insert(0, 0x00);
Expand Down

0 comments on commit 1b2f863

Please sign in to comment.