Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove react i18n #357

Merged
merged 12 commits into from
Mar 12, 2024
Merged

Feature/remove react i18n #357

merged 12 commits into from
Mar 12, 2024

Conversation

eric-burel
Copy link
Contributor

@SachaG I've started investigating moving the locale fetching functions of results towards shared, but beforehand I needed to move everything to TS to get a better view of the data structure

The thing is that surveyform uses shared logic that is more mature but uses specific locale structure, while results uses specific logic to fetching from Redis and API, but with the structure we want, I need to type these structures

As expected, it doesn't work yet the results app won't run with the TS files... but I am getting closer you might want to take a look at the error messages

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for devographics-static failed.

Name Link
🔨 Latest commit 900c95a
🔍 Latest deploy log https://app.netlify.com/sites/devographics-static/deploys/65c3ec879659350008913bf7

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for stateofjs canceled.

Name Link
🔨 Latest commit 900c95a
🔍 Latest deploy log https://app.netlify.com/sites/stateofjs/deploys/65c3ec87c940520008302c2a

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for stateofcss canceled.

Name Link
🔨 Latest commit 900c95a
🔍 Latest deploy log https://app.netlify.com/sites/stateofcss/deploys/65c3ec87f25a080008c75498

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for css2023 failed.

Name Link
🔨 Latest commit 900c95a
🔍 Latest deploy log https://app.netlify.com/sites/css2023/deploys/65c3ec87f25a080008c7549d

Copy link

render bot commented Jan 17, 2024

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for devographics-graphiql2 canceled.

Name Link
🔨 Latest commit 900c95a
🔍 Latest deploy log https://app.netlify.com/sites/devographics-graphiql2/deploys/65c3ec87425ae80008997825

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for tokyodev2022 failed.

Name Link
🔨 Latest commit 900c95a
🔍 Latest deploy log https://app.netlify.com/sites/tokyodev2022/deploys/65c3ec8719d02f00089be31c

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for state-of-graphql canceled.

Name Link
🔨 Latest commit 900c95a
🔍 Latest deploy log https://app.netlify.com/sites/state-of-graphql/deploys/65c3ec87fdb84d00094c6d1f

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for graphiql-devographics canceled.

Name Link
🔨 Latest commit 900c95a
🔍 Latest deploy log https://app.netlify.com/sites/graphiql-devographics/deploys/65c3ec878da8e50008dc3cc5

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for stateofjs2022 failed.

Name Link
🔨 Latest commit 900c95a
🔍 Latest deploy log https://app.netlify.com/sites/stateofjs2022/deploys/65c3ec87fb1b2a000892d4a8

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for devographics-graphiql-internal canceled.

Name Link
🔨 Latest commit 900c95a
🔍 Latest deploy log https://app.netlify.com/sites/devographics-graphiql-internal/deploys/65c3ec87fec3c100087adb12

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
charts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 8:49pm

@eric-burel
Copy link
Contributor Author

@SachaG for now I am stuck with gatsbyjs/gatsby#34613 (comment)
We can't import shared code in gatsby-node which prevents refactoring of the function that fetches the locale
I'll wait for an answer but if it doesn't work, I'll just rollback, and copy-paste the code into Gatsby...

@SachaG SachaG merged commit 900c95a into main Mar 12, 2024
3 of 8 checks passed
@julianCast
Copy link

@SachaG for now I am stuck with gatsbyjs/gatsby#34613 (comment) We can't import shared code in gatsby-node which prevents refactoring of the function that fetches the locale I'll wait for an answer but if it doesn't work, I'll just rollback, and copy-paste the code into Gatsby...

Same issue, did you find a solution?

@eric-burel
Copy link
Contributor Author

We are currently moving to Astro, not being able to use TypeScript in shared code is quite painful
If you need a palliative solution, you can reintroduce a build system in your shared code with whatever tools works best. We previously used Tsup but Bun has a good reputation these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants