You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@SachaG I've started investigating moving the locale fetching functions of results towards shared, but beforehand I needed to move everything to TS to get a better view of the data structure
The thing is that surveyform uses shared logic that is more mature but uses specific locale structure, while results uses specific logic to fetching from Redis and API, but with the structure we want, I need to type these structures
As expected, it doesn't work yet the results app won't run with the TS files... but I am getting closer you might want to take a look at the error messages
@SachaG for now I am stuck with gatsbyjs/gatsby#34613 (comment)
We can't import shared code in gatsby-node which prevents refactoring of the function that fetches the locale
I'll wait for an answer but if it doesn't work, I'll just rollback, and copy-paste the code into Gatsby...
@SachaG for now I am stuck with gatsbyjs/gatsby#34613 (comment) We can't import shared code in gatsby-node which prevents refactoring of the function that fetches the locale I'll wait for an answer but if it doesn't work, I'll just rollback, and copy-paste the code into Gatsby...
We are currently moving to Astro, not being able to use TypeScript in shared code is quite painful
If you need a palliative solution, you can reintroduce a build system in your shared code with whatever tools works best. We previously used Tsup but Bun has a good reputation these days.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SachaG I've started investigating moving the locale fetching functions of results towards shared, but beforehand I needed to move everything to TS to get a better view of the data structure
The thing is that surveyform uses shared logic that is more mature but uses specific locale structure, while results uses specific logic to fetching from Redis and API, but with the structure we want, I need to type these structures
As expected, it doesn't work yet the results app won't run with the TS files... but I am getting closer you might want to take a look at the error messages