fix: URL 공유 모달 뜰 때, 한번 더 클릭 시 없어지도록 변경 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
고생하셨습니다! 👍 |
dotory0829
approved these changes
Jun 30, 2024
| handleClose: () => void; | ||
| } | ||
| export function CopiedNotice({ isOpen, handleClose }: Props) { | ||
| if (isOpen) { |
There was a problem hiding this comment.
if (!isOpen) return null위처럼 명시하면 불필요한 연산을 줄이고 가독성에 좀 더 도움이 될것 같아요.
지금은 사실 단순 ui 컴포넌트라서 상관은 없지만요!!
There was a problem hiding this comment.
훨씬 좋네요! 감사합니다 덕배!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 기능 설명
📌 구현 내용
URL 공유 안내 모달이 한번 더 클릭 시 없어지도록 변경했습니다.
상태의 props를 받는 형식으로 변경했습니다.
📌 구현 결과
📌 논의하고 싶은 점
사파리에서 URL을 복사하지 않는 이슈가 있었는데, 갑자기 가능해져서, 확인할 수 없게 되었습니다. 지켜봐야 할 필요성이 있습니다!