Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated mixins with Text component in loading-swaps-quotes #56

Closed
wants to merge 2 commits into from

Conversation

staging-devin-ai-integration[bot]
Copy link

@staging-devin-ai-integration staging-devin-ai-integration bot commented Jun 13, 2024

Description

This pull request replaces deprecated mixins with the Text component in the loading-swaps-quotes file. The changes include updating the SCSS and JS files to use the Text component and related enums, as well as deleting specific SCSS instances as instructed by the user.

Devin Run Link: https://staging.itsdev.in/devin/edffa827e63141c8a3214c25ecf4a760

Open in GitHub Codespaces

Related issues

Partially Fixes: MetaMask#20496

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Manually check if LoadingSwapQuotes is getting rendered properly

Screenshots/Recordings

Before

After

Screenshot 2024-06-13 at 22 01 58

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Requested by: Shreyasi

@Devin-Apps Devin-Apps closed this Jun 27, 2024
@Devin-Apps Devin-Apps deleted the devin/mixin-xyz branch June 27, 2024 11:17
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated mixins @include H1 - @include H9 in SCSS with Text component
1 participant