Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #20496: Replace deprecated mixins with Text component in selected-account.component.js #47

Closed
wants to merge 5 commits into from

Conversation

devin-ai-integration[bot]
Copy link

@devin-ai-integration devin-ai-integration bot commented Jun 11, 2024

Description

Replaced deprecated mixins with Text component in selected-account.component.js. The change aims to modernize the codebase by using the Text component from the design system, ensuring consistency and maintainability.

Devin Run Link: https://preview.devin.ai/devin/6dcddd7b3ee2456ca004b34d033b0d82

Open in GitHub Codespaces

Related issues

Partially Fixes: MetaMask#20496

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Verify the "SelectedAccount" component displays correctly with the updated Text component.

Screenshots/Recordings

Before

After

Screenshot 2024-06-12 at 01 13 59

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Devin-Apps
Copy link
Member

Draft PR created - closing this

@Devin-Apps Devin-Apps closed this Jun 12, 2024
@Devin-Apps Devin-Apps deleted the devin/mixin-Pzg branch June 12, 2024 16:26
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated mixins @include H1 - @include H9 in SCSS with Text component
1 participant