Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test descriptions to active voice #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link

Update Test Descriptions to Active Voice

Description

This pull request updates the test descriptions in the AddressBookController.test.ts file from passive voice using 'should' to active voice. The changes are made to improve the readability and clarity of the test descriptions.

Changes Made

  • Updated test descriptions to active voice by removing 'should' and adjusting the verb tense.
  • Ensured that no test descriptions were updated if they did not contain the word 'should'.

Updated Test Descriptions

  • it('sets default state', () => {
  • it('adds a contact entry', () => {
  • it('adds a contact entry with chainId and memo', () => {
  • it('adds a contact entry with address type contract accounts', () => {
  • it('adds a contact entry with address type non accounts', () => {
  • it('adds multiple contact entries with different chainIds', () => {
  • it('updates a contact entry', () => {
  • it('does not add invalid contact entry', () => {
  • it('removes one contact entry', () => {
  • it('removes only one contact entry', () => {
  • it('adds two contact entries with the same chainId', () => {
  • it('correctly marks ens entries', () => {
  • it('clears all contact entries', () => {
  • it('returns true to indicate an address book entry has been added', () => {
  • it('returns false to indicate an address book entry has NOT been added', () => {
  • it('returns true to indicate an address book entry has been deleted', () => {
  • it('returns false to indicate an address book entry has NOT been deleted due to unsafe input', () => {
  • it('returns false to indicate an address book entry has NOT been deleted', () => {
  • it('normalizes addresses so adding and removing entries work across casings', () => {

Checklist

  • Updated test descriptions to active voice.
  • Ensured that no test descriptions were updated if they did not contain the word 'should'.
  • Committed the changes to the branch Devin/test-description-address-book-controller-5FA.
  • Created a pull request for the changes.

Link to Devin run

https://preview.devin.ai/devin/6a35c72744c0440a8f9477c7452f75ca

Requested by

Noah

Please review the changes and provide feedback. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants