Update test descriptions to active voice #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Test Descriptions to Active Voice
Description
This pull request updates the test descriptions in the
AddressBookController.test.ts
file from passive voice using 'should' to active voice. The changes are made to improve the readability and clarity of the test descriptions.Changes Made
Updated Test Descriptions
it('sets default state', () => {
it('adds a contact entry', () => {
it('adds a contact entry with chainId and memo', () => {
it('adds a contact entry with address type contract accounts', () => {
it('adds a contact entry with address type non accounts', () => {
it('adds multiple contact entries with different chainIds', () => {
it('updates a contact entry', () => {
it('does not add invalid contact entry', () => {
it('removes one contact entry', () => {
it('removes only one contact entry', () => {
it('adds two contact entries with the same chainId', () => {
it('correctly marks ens entries', () => {
it('clears all contact entries', () => {
it('returns true to indicate an address book entry has been added', () => {
it('returns false to indicate an address book entry has NOT been added', () => {
it('returns true to indicate an address book entry has been deleted', () => {
it('returns false to indicate an address book entry has NOT been deleted due to unsafe input', () => {
it('returns false to indicate an address book entry has NOT been deleted', () => {
it('normalizes addresses so adding and removing entries work across casings', () => {
Checklist
Devin/test-description-address-book-controller-5FA
.Link to Devin run
https://preview.devin.ai/devin/6a35c72744c0440a8f9477c7452f75ca
Requested by
Noah
Please review the changes and provide feedback. Thank you!