Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoother default configuration #21

Merged
2 commits merged into from
Apr 11, 2019
Merged

Smoother default configuration #21

2 commits merged into from
Apr 11, 2019

Conversation

tleguern
Copy link
Contributor

@tleguern tleguern commented Apr 9, 2019

Define haproxy_chroot_dir and use haproxy_config_dir in the default configuration.

@tleguern
Copy link
Contributor Author

tleguern commented Apr 9, 2019

Tested against Debian jessie.

@tleguern tleguern requested a review from a user April 9, 2019 15:19
@tleguern
Copy link
Contributor Author

tleguern commented Apr 9, 2019

Would close issue #16.

@kurotoshiro kurotoshiro self-requested a review April 10, 2019 14:07
kurotoshiro
kurotoshiro approved these changes Apr 10, 2019
View reviewed changes
Copy link
Collaborator

@kurotoshiro kurotoshiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Ok for me

@ghost
Copy link

ghost commented Apr 11, 2019

Thank you for your PR.

@ghost ghost merged commit b160bd5 into Deveryware:master Apr 11, 2019
@tleguern tleguern deleted the haproxy-config-dir branch April 11, 2019 13:37
@ghost ghost added this to the v1.3.0 milestone Apr 11, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurotoshiro kurotoshiro kurotoshiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tleguern @kurotoshiro