Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved SCSS and TypeScript build #986

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Improved SCSS and TypeScript build #986

merged 6 commits into from
Nov 28, 2023

Conversation

veler
Copy link
Collaborator

@veler veler commented Nov 27, 2023

Changing the way we build CSS and JavaScript:

Before this PR:

  1. Had to open Task Runner Explorer in VS in order to get SCSS and TypeScript built
  2. It was easy to forget it when doing a change in a SCSS or TypeScript file.
  3. We were not committing the generated CSS and JS, forcing every contributor to build them themselves.

With this PR:

  1. We commit the generated CSS and JS.
  2. We will only build the SCSS and TypeScript if we detect that a SCSS or TypeScript file is more recent than the generated CSS and JS. The CSS/JS build happens during DevToys.Blazor build.
  3. As a consequence, no need to have to rely on Task Runner Explorer, or at least it makes it now optional.

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler added the devtoys-v2.0 DevToys v2.0 label Nov 27, 2023
@veler veler requested a review from btiteux November 27, 2023 01:41
@veler veler merged commit ecdcbfa into dev/2.0 Nov 28, 2023
@veler veler deleted the dev/2.0-net8 branch November 28, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtoys-v2.0 DevToys v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants