Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Base64 Image Encoder / Decoder #951

Merged
merged 7 commits into from
Oct 15, 2023
Merged

Added Base64 Image Encoder / Decoder #951

merged 7 commits into from
Oct 15, 2023

Conversation

veler
Copy link
Collaborator

@veler veler commented Sep 30, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Missing Base64 Image Encoder / Decoder in DevToys 2.0

What is the new behavior?

  • Added Base64 Image Encoder / Decoder
  • Added IUIImageViewer element
  • Refactored the PickedFile class and renamed it to SandboxedFileReader
  • Added support for self-cleaning temp files in IFileStorage.

REMAINS TO DO

  • Base64 Image Encoder / Decoder CLI tool
  • Unit tests

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler added feature Feature / Tool request or idea devtoys-v2.0 DevToys v2.0 labels Sep 30, 2023
@veler veler requested a review from btiteux September 30, 2023 04:16
@veler veler merged commit 6c1f2c6 into dev/2.0 Oct 15, 2023
@veler veler deleted the dev/2.0-base64image branch October 15, 2023 23:25
@veler veler linked an issue Oct 16, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtoys-v2.0 DevToys v2.0 feature Feature / Tool request or idea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base64 image crash
1 participant