Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display selected options in regex tester #798

Merged

Conversation

akarboush
Copy link
Contributor

@akarboush akarboush commented Apr 14, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

image

Issue Number: #410

What is the new behavior?

ezgif com-video-to-gif

Other information

The commit was made back in June 2022. It's time to create a PR for it 😁.

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler
Copy link
Collaborator

veler commented Apr 26, 2023

Thank you very much for this contribution! :D I will keep the issue opened as we're planning to do this in DevToys 2.0 too, but we will have a generic approach (long story short, the API for making tools will be very different and this kind of mechanism will be automated to every tools).

@veler veler merged commit 9ec4dde into DevToys-app:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants