Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding url encoding wrapper function to handle xaml textbox conversio… #789

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

jlevier
Copy link

@jlevier jlevier commented Apr 5, 2023

…n of new line to only carriage return

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #758

What is the new behavior?

Other information

screenshot

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

src/dev/impl/DevToys/Helpers/UrlHelper.cs Outdated Show resolved Hide resolved
@veler
Copy link
Collaborator

veler commented Apr 5, 2023

Hi @jlevier ,

Thanks for this pull request. It looks great!

As a heads-up, it may be fixed in DevToys 2.0 in a different manner as we plan to use Monaco Editor for every multiline editors. But we didn't try it yet for this particular scenario. Anyway, we will make sure to keep this new unit test and adapt it when we port this tool to dev/2.0 branch.

@jlevier jlevier force-pushed the bugfix/url-encode-new-lines branch from b311afb to 62d3110 Compare April 5, 2023 21:03
@jlevier
Copy link
Author

jlevier commented Apr 5, 2023

Ok, sounds great. Thank you so much for the speedy review!

@veler veler merged commit d2d6f78 into DevToys-app:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants