feat: support namespace analysis #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "XML Validator" tool is now able to detect inconsistencies in XML namespace references for both the XML and the XSD data. This capability will prevent "always true" validation cases potentially caused by validating XML data without the correct namespace scopes. Refs: DevToys-app#604
veler
reviewed
Sep 18, 2022
src/dev/impl/DevToys/ViewModels/Tools/Text/XmlValidator/NamespaceHelper.cs
Outdated
Show resolved
Hide resolved
src/dev/impl/DevToys/ViewModels/Tools/Text/XmlValidator/NamespaceHelper.cs
Outdated
Show resolved
Hide resolved
src/dev/impl/DevToys/ViewModels/Tools/Text/XmlValidator/NamespaceHelper.cs
Outdated
Show resolved
Hide resolved
src/dev/impl/DevToys/ViewModels/Tools/Text/XmlValidator/NamespaceHelper.cs
Outdated
Show resolved
Hide resolved
src/dev/impl/DevToys/ViewModels/Tools/Text/XmlValidator/Parsing/XsdParser.cs
Outdated
Show resolved
Hide resolved
|
Hi Etienne! |
veler
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Awesome! Thank you so much for addressing this feedback :D
I will merge the changes. Thank you for your contribution !
An update (1.0.10.0) is schedule to be released tomorrow. It won't include your changes though. They will go into the next update (likely 1.0.11.0)
veler
pushed a commit
that referenced
this pull request
Mar 31, 2023
* feat: support namespace analysis The "XML Validator" tool is now able to detect inconsistencies in XML namespace references for both the XML and the XSD data. This capability will prevent "always true" validation cases potentially caused by validating XML data without the correct namespace scopes. Refs: #604 * fix: apply MR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "XML Validator" tool is now able to detect inconsistencies in XML namespace references for both the XML and the XSD data.
This capability will prevent "always true" validation cases potentially caused by validating XML data without the correct namespace scopes.
Refs: #604
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #604
What is the new behavior?
The tool is now able to detect unreflected namespace reference and issue an according warning.
Example: The XML data defines a "xmlns" namespace not defined in the XSD => result of the data validation will always be 'valid', a warning is ejected.
Other information
Quality check
Before creating this PR, have you: