Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced all SVG icons by TTF font #585

Merged
merged 10 commits into from
Jul 13, 2022
Merged

Replaced all SVG icons by TTF font #585

merged 10 commits into from
Jul 13, 2022

Conversation

veler
Copy link
Collaborator

@veler veler commented Jul 12, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

In DevToys, a good part of the tools icons come from SVG files shipped with the app.
These SVG files are loaded asynchronously. The theme is applied to the SVG, then it's being loaded by the UI engine, then when the size is applied, we scale it by.... reloading it with the size we know about...

This is:

  1. EXPENSIVE. That's why DevToys takes up to 1 second to display all the icons on a slow machine.
  2. NOT-MEMORY-FRIENDLY. This is the root cause of Memory leak in SearchResults #369.

Issue Number: #369, #416

What is the new behavior?

Replaced all the SVG by a TTF font.

Other information

BEFORE

image

AFTER

image

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler added bug Something isn't working enhancement Idea of improvement of existing feature. labels Jul 12, 2022
@veler veler requested a review from btiteux July 12, 2022 06:51
This was linked to issues Jul 12, 2022
@veler veler merged commit 37c70c7 into main Jul 13, 2022
@veler veler deleted the new-font branch July 13, 2022 05:00
veler added a commit that referenced this pull request Mar 31, 2023
* Backup

* Migrated all tools icons to a font.

* Fixed bug with Pin To Start

* Added Color Picker icon

* Updated documentation

* updated icon

* Fixed build

* Removed `using`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Idea of improvement of existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project FontIcon glyph list Memory leak in SearchResults
1 participant